Adds support for Accelerate and Dualstack for s3, s3control client #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
reviewed
Oct 20, 2020
...egen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3UpdateEndpoint.java
Show resolved
Hide resolved
...egen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3UpdateEndpoint.java
Show resolved
Hide resolved
...egen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/S3UpdateEndpoint.java
Outdated
Show resolved
Hide resolved
skotambkar
force-pushed
the
s3-accel-dualstack
branch
from
88210a3
to
a06a201
Compare
jasdel
approved these changes
Oct 22, 2020
skotambkar
force-pushed
the
s3-accel-dualstack
branch
from
b44559b
to
4451b4a
Compare
jasdel
added a commit
that referenced
this pull request
Oct 27, 2020
…oint or not Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false. - Fixes #827 (SDK requiring region for endpoint resolution) - Fixes #328 - Fixes #364 - Related to #836 When Amazon S3 Accesspoint support is implemented. - Related to #479 Depends on aws/smithy-go#222
jasdel
added a commit
that referenced
this pull request
Oct 27, 2020
…oint or not Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false. - Fixes #827 (SDK requiring region for endpoint resolution) - Fixes #328 - Fixes #364 - Related to #836 When Amazon S3 Accesspoint support is implemented. - Related to #479 Depends on aws/smithy-go#222
jasdel
added a commit
that referenced
this pull request
Oct 27, 2020
Adds a new member to the `aws.Endpoint` struct, `HostnameImmutable`. This member directs if the SDK is allowed to modify the resolved endpoint to meet the requirements of the API. If `HostnameImmutable` is true, the SDK will not attempt to modify the hostname via any customizations, or prefix behavior. Flag defaults to false. - Fixes #827 (SDK requiring region for endpoint resolution) - Fixes #328 - Fixes #364 - Related to #836 When Amazon S3 Accesspoint support is implemented. - Related to #479 Depends on aws/smithy-go#222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3:
S3Control: