-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerated Clients with Paginator Support #885
Conversation
c113f2f
to
c599e40
Compare
94eec8d
to
08528f3
Compare
08528f3
to
59a6550
Compare
df2329d
to
12c669f
Compare
What do you think about the following as a way we can simplify some of the logic around that The Paginator should auto fill This strategy highlights a question: What if user wants to clear the page size limit via the Limit option? How would this be done? Would Limit option value of 0 be translated to be the zero value of a boxed limit input member? // For boxed PageSize
var options PaginatorOptions
options = ptr.ToInt32(input.PageSize)
// For unboxed PageSize
var options PaginatorOptions
options.Limit = input.PageSize // if PageSize is boxed
if p.options.Limit == 0 {
input.PageSize = nil
} else {
input.PageSize = ptr.Int32(p.options.Limit)
}
// if PageSize is unboxed
input.PageSize = p.options.Limit The above has one notable downside it is impossible to send a page size of 0 with this strategy. Arguably that probably is OK, because the behavior isn't really well defined if 0 were to be sent, Could be failure be service, could be infinite loop, service could ignore page size and use a default. |
12c669f
to
ee410c1
Compare
ee410c1
to
55b095c
Compare
55b095c
to
0118d43
Compare
Adds support for paginators.
Related #820
Related aws/aws-sdk-go#3513
Closes #439
Depends on:
aws/smithy-go#234
smithy-lang/smithy#628