Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/transport/http: Move aws.BuildableHTTPClient to http transport package #898

Merged
merged 7 commits into from
Nov 13, 2020

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Nov 12, 2020

Moves the BuildableHTTPClient from the SDK's aws package to the aws/transport/http package as BuildableClient to with other HTTP specific utilities.

Updates the BuildableClient's method return type to be the BuildableClient type to make chaining With statements more natural.

Fixes #730

…ckage

Moves the BuildableHTTPClient from the SDK's `aws` package to the
`aws/transport/http` package as `BuildableClient` to with other HTTP specific
utilities.

Updates the BuildableClient's method return type to be the
BuildableClient type to make chaining `With` statements more natural.

Fixes #730
aws/transport/http/client.go Outdated Show resolved Hide resolved
aws/transport/http/client.go Show resolved Hide resolved
aws/transport/http/client.go Outdated Show resolved Hide resolved
ec2imds/api_client.go Show resolved Hide resolved
@jasdel jasdel merged commit 5b010cb into master Nov 13, 2020
@jasdel jasdel deleted the jasdel/fixupBuildableClient branch November 13, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws.BuildableHTTPClient with options method pattern is awkward to use.
3 participants