dynamodb/attributevalue: Add utility to (un)marshal Attribtue Values #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
ddbAttrib
branch
2 times, most recently
from
dab9029
to
fded929
Compare
skmcgrail
reviewed
Dec 10, 2020
skmcgrail
reviewed
Dec 10, 2020
jasdel
force-pushed
the
ddbAttrib
branch
2 times, most recently
from
132bcfc
to
a852eef
Compare
Adds support for * Fixes aws#895 - Add support for attribute value marshaling * Fixes aws#929 - Support Number type aliases of string for support for json.Number like types. * Fixes aws#115 - Simplifies the rules of `null` vs skipped vs zero value for all types. * All nil pointers, map, slice members are serialized as NULL. * omitempty struct tag skips zero value of members with the struct tag. * Empty and Nil Sets (NS, BS, SS) are serialized to null by default unless `NullEmptySets` EncoderOptions is set to false. True by default. Nil sets are always serialized as NULL, unless the `omitempty` struct tag is used. * Adds `nullempty` and `nullemptyelem` struct tags to direct if the encoder should marshal the member as a AttributeValue NULL if the member's value is the type's zero value, (e.g. "" for string, 0 for number, nil for pointer/map/slice, false for bool)
skmcgrail
reviewed
Dec 15, 2020
Comment on lines
+170
to
+171
| _, isNull := av.(*types.AttributeValueMemberNULL) | ||
| if av == nil || isNull { |
There was a problem hiding this comment.
If av is not nil and the type is AttributeValueMemberNULL should this check that av.Value == true?
There was a problem hiding this comment.
It would be odd if it was set to false, but it's the more correct check.
There was a problem hiding this comment.
We could check if Value is false. I'll check if Dynamo looks at this value. I had a feeling it ignored or always set the value to true on its side. A value of false doesn't really have any clear meaning. (Other than potentially error)
skmcgrail
approved these changes
Dec 15, 2020
skmcgrail
reviewed
Dec 15, 2020
skmcgrail
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds utilities for mapping Amazon DynamoDB API AttributeValue to and from Go types.
Adds conversion util for DynamoDB -> DynamoDBStreams AttributeValue.
Fixes dynamodb/attributevalue: Add AttributeValue marshaler utilities #895 - Adds back marshaler/unmarshalers for attribute value to/from go types.
Fixes dynamodb/attributevalue: Marshal does not support json.Number to Numeric data type #929 - Adds generic support for
json.Numberlike types that are aliases ofstrings.Fixes dynamodb/attributevalue: Consider changing default behavior for empty maps and slices #115 - Simplifies the rules of
nullvs skipped vs zero valuefor all types.
omitemptystruct tag skips zero value of members with the struct tag.omitemptyelemskips elements of list/map that have zero value.nullemptystruct tag serializes zero value of members with the struct tag as NULL AttributeValue.nullemptyelemdoes same for elements of list/map that have zero value.NullEmptySetsEncoderOptions is set to false. True by default. Nil sets are always serialized as NULL, unless theomitemptystruct tag is used.nullemptyandnullemptyelemstruct tags to direct if the encoder should marshal the member as a AttributeValue NULL if the member's value is the type's zero value, (e.g. "" for string, 0 for number, nil for pointer/map/slice, false for bool)TODO: