Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds resolver function for loading S3 client specific config #991

Merged
merged 4 commits into from
Dec 21, 2020
Merged

Adds resolver function for loading S3 client specific config #991

merged 4 commits into from
Dec 21, 2020

Conversation

skotambkar
Copy link
Contributor

@skotambkar skotambkar commented Dec 21, 2020 •
edited
Loading

  • Adds resolver function for loading client specific config

Fixes #968

@skotambkar skotambkar requested review from skmcgrail and jasdel and removed request for skmcgrail December 21, 2020 17:13
jasdel
jasdel reviewed Dec 21, 2020
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update the gohash's for s3 and s3control modules to depend on the update with service/internal/s3shared having the config load behavior.

...-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/ResolveClientConfig.java Show resolved Hide resolved
service/s3/api_client.go Outdated Show resolved Hide resolved
@skotambkar skotambkar merged commit 15e052d into master Dec 21, 2020
@skmcgrail skmcgrail deleted the s3-external-config branch March 13, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

@skmcgrail skmcgrail Awaiting requested review from skmcgrail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

S3 Client Must Load Client Specific Options from aws.Config#ConfigSources
2 participants
@skotambkar @jasdel