Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help fixing bug in retryer.go #3026

Closed
swami-m opened this issue Dec 17, 2019 · 2 comments
Closed

Help fixing bug in retryer.go #3026

swami-m opened this issue Dec 17, 2019 · 2 comments
Assignees

Comments

@swami-m
Copy link
Contributor

swami-m commented Dec 17, 2019

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

Any recent version

Version of Go (go version)?

Go 1.6.x

What issue did you see?

The behavior of IsErrorRetryable seems to be incorrect in case of nested errors due to a Go shadowing issue. I've attempted to fix it in #3017
However, I'm running into some other test failures, which I'm failing to connect to the issue I'm fixing. Perhaps someone more familiar with this could tell me what's wrong or perhaps take over the fix ?

Steps to reproduce

See the Travis build failure for PR #3017

If you have an runnable example, please include it.

@skmcgrail skmcgrail self-assigned this Dec 17, 2019
@swami-m
Copy link
Contributor Author

swami-m commented Dec 18, 2019

Thanks for addressing this @skmcgrail

@skmcgrail
Copy link
Member

I've merged #3017. Thank you for contributing a fix and bringing it to our attention @swami-m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants