Fix shouldRetry behavior for nested errors #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
added
the
needs-review
`shouldRetryError` should be using the `var shouldRetry` defined in outer scope and not declare another.
skmcgrail
approved these changes
Dec 18, 2019
jasdel
approved these changes
Dec 18, 2019
skmcgrail
removed
the
needs-review
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Dec 18, 2019
=== ### Service Client Updates * `service/cloudfront`: Updates service documentation * Documentation updates for CloudFront * `service/ec2`: Updates service API and documentation * This release introduces the ability to tag Elastic Graphics accelerators. You can use tags to organize and identify your accelerators for cost allocation. * `service/opsworkscm`: Updates service API and documentation * AWS OpsWorks CM now supports tagging, and tag-based access control, of servers and backups. * `service/resourcegroupstaggingapi`: Updates service documentation * Documentation updates for resourcegroupstaggingapi * `service/s3`: Updates service documentation * Updates Amazon S3 endpoints allowing you to configure your client to opt-in to using S3 with the us-east-1 regional endpoint, instead of global. ### SDK Bugs * `aws/request`: Fix shouldRetry behavior for nested errors ([#3017](#3017))
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Dec 18, 2019
Release v1.26.5 (2019-12-18) === ### Service Client Updates * `service/cloudfront`: Updates service documentation * Documentation updates for CloudFront * `service/ec2`: Updates service API and documentation * This release introduces the ability to tag Elastic Graphics accelerators. You can use tags to organize and identify your accelerators for cost allocation. * `service/opsworkscm`: Updates service API and documentation * AWS OpsWorks CM now supports tagging, and tag-based access control, of servers and backups. * `service/resourcegroupstaggingapi`: Updates service documentation * Documentation updates for resourcegroupstaggingapi * `service/s3`: Updates service documentation * Updates Amazon S3 endpoints allowing you to configure your client to opt-in to using S3 with the us-east-1 regional endpoint, instead of global. ### SDK Bugs * `aws/request`: Fix shouldRetry behavior for nested errors ([#3017](#3017))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shouldRetryErrorshould be using thevar shouldRetrydefined in outer scope and not declare another.