Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route53 HealthCheck #420

Closed
stack72 opened this issue Nov 3, 2015 · 5 comments
Closed

Route53 HealthCheck #420

stack72 opened this issue Nov 3, 2015 · 5 comments
Labels
guidance Question that needs advice or information.

Comments

@stack72
Copy link

stack72 commented Nov 3, 2015

Right now, the go-sdk allows us to enable latency graphs as part of the CreateHealthCheckInput as follows:

healthConfig := &route53.HealthCheckConfig{
        Type:             aws.String(d.Get("type").(string)),
        FailureThreshold: aws.Int64(int64(d.Get("failure_threshold").(int))),
        RequestInterval:  aws.Int64(int64(d.Get("request_interval").(int))),
                MeasureLatency: aws.Bool(d.Get("measure_latency").(bool)),
    }
input := &route53.CreateHealthCheckInput{
        CallerReference:   aws.String(time.Now().Format(time.RFC3339Nano)),
        HealthCheckConfig: healthConfig,
    }

    resp, err := conn.CreateHealthCheck(input)

there is currently no way to be able to update the measure latency flag as part of the UpdateHealthCheck request

Was this a deliberate omission?

@jasdel
Copy link
Contributor

jasdel commented Nov 4, 2015

Hi @stack72, Are you getting an error response? If so what is the error you're getting.

@jasdel jasdel added the guidance Question that needs advice or information. label Nov 4, 2015
@stack72
Copy link
Author

stack72 commented Nov 4, 2015

@jasdel thanks forgetting back to me. I'm not getting an error response - I just cannot change the value of MeasureLatency once it is set

@jasdel
Copy link
Contributor

jasdel commented Nov 4, 2015

@stack72 the issue you are seeing is intentional. Once the MeasureLatency is set on a Route53 health check it cannot be changed. Since the MeasureLatency cannot be changed during an update, the only option is to delete the health check, and recreate it with MeasureLatency, set to the value you want.

@stack72
Copy link
Author

stack72 commented Nov 4, 2015

Thanks @jasdel - thought that may be the case :) Thanks for getting back to me here!

@stack72 stack72 closed this as completed Nov 4, 2015
@jasdel
Copy link
Contributor

jasdel commented Nov 4, 2015

Glad to help, let us know if have any other questions, feedback, or issues.

skotambkar pushed a commit to skotambkar/aws-sdk-go that referenced this issue May 20, 2021
Fixes the SDK's endpoint resolve incorrectly resolving endpoints for a
service when the region is empty. Also fixes the SDK attempting to
resolve a service when the service value is empty.

Related to: aws#2911
skotambkar added a commit to skotambkar/aws-sdk-go that referenced this issue May 20, 2021
* Release v0.18.0 (2019-12-12)
===

Services
---
* Synced the V2 SDK with latest AWS service API definitions.

SDK Bugs
---
* `aws/endpoints`: aws/endpoints: Fix SDK resolving endpoint without region ([aws#420](aws/aws-sdk-go-v2#420))
  * Fixes the SDK's endpoint resolve incorrectly resolving endpoints for a service when the region is empty. Also fixes the SDK attempting to resolve a service when the service value is empty.
  * Related to [aws#2909](aws#2909)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information.
Projects
None yet
Development

No branches or pull requests

2 participants