-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test github.com/aws/aws-sdk-go/aws/session fails with Go 1.18 due to SHA1 being rejected by default. #4316
Closed
3 tasks done
Labels
bug
This issue is a bug.
Comments
jawn-smith
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Mar 16, 2022
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this issue
Mar 16, 2022
Updates the SDK's custom certificate testing utilities to be compatible with Go 1.18's deprecating of SHA1. Switch from static openssl generated certificates to generate certificates at package initialization. Fixes: aws#4316
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this issue
Mar 16, 2022
Updates the SDK's custom certificate testing utilities to be compatible with Go 1.18's deprecating of SHA1. Switch from static openssl generated certificates to generate certificates at package initialization. Related to aws/aws-sdk-go#4316
This was referenced Mar 16, 2022
Thanks for reporting this issue @GlenPickle I've created PR #4318 updating the SDK's unit tests for Go 1.18. |
jasdel
added a commit
to jasdel/aws-sdk-go
that referenced
this issue
Mar 16, 2022
Updates the SDK's custom certificate testing utilities to be compatible with Go 1.18's deprecating of SHA1. Switch from static openssl generated certificates to generate certificates at package initialization. Fixes: aws#4316
jasdel
added a commit
that referenced
this issue
Mar 23, 2022
Updates the SDK's custom certificate testing utilities to be compatible with Go 1.18's deprecating of SHA1. Switch from static openssl generated certificates to generate certificates at package initialization. Fixes: #4316
|
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this issue
Mar 30, 2022
Updates the SDK's custom certificate testing utilities to be compatible with Go 1.18's deprecating of SHA1. Switch from static openssl generated certificates to generate certificates at package initialization. Related to aws/aws-sdk-go#4316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Confirm by changing [ ] to [x] below to ensure that it's a bug:
Describe the bug
TestNewSession_WithCustomCABundle* fails with Go 1.18
Version of AWS SDK for Go?
1.43.19
Version of Go (
go version
)?1.18
To Reproduce (observed behavior)
go test ./...
Expected behavior
Tests pass
Additional context
This was discovered in Ubuntu while moving from Go 1.17 to 1.18 for the upcoming 22.04 release. Per the Go 1.18 release notes (https://go.dev/doc/go1.18) SHA1 is now rejected by default for security reasons.
The text was updated successfully, but these errors were encountered: