Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/credentials: Fix shared credential providers filename #1312

Merged
merged 1 commit into from
Jun 1, 2017

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Jun 1, 2017

In #1308 the filename was being retrieved with the SharedConfigFilename
utility function not SharedCredentialsFilename function.

This bug caused the session.New with the SharedCredentials file to break.

Fix #1313

In aws#1308 the filename was being retrieved with the SharedConfigFilename
utility function not SharedCredentialsFilename function.
@jasdel jasdel self-assigned this Jun 1, 2017
@jasdel jasdel merged commit a6b7ec5 into aws:master Jun 1, 2017
@jasdel jasdel deleted the fix/SharedCredentialsProviderFilename branch June 1, 2017 19:36
jasdel added a commit that referenced this pull request Jun 2, 2017
)

Adds tests for SharedCredentialProvider ensuring the correct default shared credential file is used if none is provided.

Related #1308 #1312 #1313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant