Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private/model/api: Fix RESTXML support for XML Namespace #1343

Merged
merged 2 commits into from
Jun 14, 2017

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Jun 13, 2017

Fixes a bug with the SDK's generation of services using the REST XML
protocol not annotating shape references with the XML Namespace
attribute.

The XML Namespace URI was incorrectly being limited to the top level
API shape, where it should of applied to all levels.

Fix #1334

Fixes a bug with the SDK's generation of services using the REST XML
protocol not annotating shape references with the XML Namespace
attribute.

Fix aws#1334
@jasdel jasdel self-assigned this Jun 13, 2017
@jasdel jasdel requested a review from xibz June 13, 2017 23:32
Copy link
Contributor

@xibz xibz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@jasdel jasdel merged commit 63041ae into aws:master Jun 14, 2017
@jasdel jasdel deleted the fix/s3XmlRequest branch June 14, 2017 23:32
jasdel added a commit that referenced this pull request Jun 14, 2017
@awstools awstools mentioned this pull request Jun 15, 2017
@diehlaws diehlaws added needs-review This issue or pull request needs review from a core team member. and removed review-needed labels Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants