This is an example using the AWS SDK for Go to list ec2 instances ins… #1481
Conversation
…tance state By different region . By default it fetch all running and stopped instance
There was a problem hiding this comment.
Hello @piusranjan, thank you for taking the time to put this together. I have a few comments that I think is mostly for consistency.
| } | ||
| } else { | ||
| States= []*string{ | ||
| aws.String("running"), |
There was a problem hiding this comment.
Use constants here, like ec2.InstanceStateNameRunning
There was a problem hiding this comment.
I would either get rid of this else statement or not pass in states
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/aws/aws-sdk-go/aws/session" |
There was a problem hiding this comment.
nit, but generally we put stdlib stuff separate from SDK imports
import (
"fmt"
"os"
"github.com/aws/aws-sdk-go/aws/session"
// and so on
)There was a problem hiding this comment.
@xibz . Thank. I will change this.
| ) | ||
|
|
||
| func fetchRegion()[]string{ | ||
|
|
There was a problem hiding this comment.
Remove the unneeded whitespace here for consistency.
|
|
||
| regions := []string{} | ||
| sess1 := session.Must(session.NewSession(&aws.Config{ | ||
| Region: aws.String("us-west-1"), |
There was a problem hiding this comment.
Region shouldn't be hard coded, please pass this in via command line
| })) | ||
|
|
||
| svc := ec2.New(sess1) | ||
| awsregions, err := svc.DescribeRegions(&ec2.DescribeRegionsInput{}) |
There was a problem hiding this comment.
whitespace not properly aligned. Run go fmt to fix this
There was a problem hiding this comment.
I am new to go. I will take care.
|
|
||
| svc := ec2.New(sess1) | ||
| awsregions, err := svc.DescribeRegions(&ec2.DescribeRegionsInput{}) | ||
| if err != nil { |
There was a problem hiding this comment.
Why do we not want to return this error?
There was a problem hiding this comment.
Yes I will change it. It should .
| aws.String("running"), | ||
| aws.String("pending"), | ||
| aws.String("stopped"), | ||
| } |
There was a problem hiding this comment.
whitespace not following Go standard
| &ec2.Filter{ | ||
| Name: aws.String("instance-state-name"), | ||
| Values: States, | ||
| }, |
| States:= []*string{} | ||
| if len(os.Args)>1 { | ||
| for i := 1; i < len(os.Args); i++ { | ||
| States=append(States,&os.Args[i]) |
There was a problem hiding this comment.
region should be passed in via command line as well
|
|
||
| Fetching instace details for region: ap-south-1 | ||
| printing instance details..... | ||
| instance id i-00cf3fcsssdd373766 |
There was a problem hiding this comment.
probably want some mock value here like x-000000000000000000
There was a problem hiding this comment.
@xibz , what mock value you mean to say? Are you talking about any unit test with some mock value?
|
@xibz . Thanks for all your valuable review . I will change all according to your sugesstion |
|
@xibz , I have made changes as per your suggestion. Please have a look. |
|
Not sure why the build is failing in github.com/aws/aws-sdk-go/service/s3/s3manager for go 1.6. How my code is related to that module? |
|
Closing because I will create a new PR to make a fresh build |
|
Thanks for updating the CR @piusranjan I've taking your changes with minor tweaks to #1492. I'll close this PR and merge in the new one. |
Adds an example using the AWS SDK for Go to list EC2 instances instance state by different region. Minor tweak of #1481 for style and example consistence.
|
@jasdel thanks. |
This is an example using the AWS SDK for Go to list ec2 instances instance state by different region . By default it fetch all running and stopped instance
Usage go run filter_ec2_by_region running