Handle nil token returned by ssooidc #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
reviewed
Aug 17, 2023
| @@ -111,6 +111,10 @@ func (p *SSOTokenProvider) refreshToken(token cachedToken) (cachedToken, error) | |||
| if err != nil { | |||
| return cachedToken{}, fmt.Errorf("unable to refresh SSO token, %v", err) | |||
| } | |||
| if createResult == nil || createResult.ExpiresIn == nil || | |||
| createResult.AccessToken == nil || createResult.RefreshToken == nil { | |||
| return cachedToken{}, fmt.Errorf("CreateToken returned some nil val without err") | |||
There was a problem hiding this comment.
We should limit the scope of this change e.g.
if createResult.ExpiresIn == nil {
return cachedToken{}, fmt.Errorf("missing required field ExpiresIn")
}
lucix-aws
approved these changes
Aug 18, 2023
isaiahvita
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify sso token provider logic to handle possible nil token val returned by ssooidc CreateToken op, possibly will resolve #4947