Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race in EC2Metadata client initialization #511

Merged
merged 2 commits into from
Jan 16, 2016
Merged

Fix data race in EC2Metadata client initialization #511

merged 2 commits into from
Jan 16, 2016

Commits on Jan 16, 2016

  1. Fix data race in EC2Metadata client initialization 

    The EC2Metadata client was taking a copy of http.Client's Transporter
which is not safe. This also complicated the implementation preventing
custom configurations by users. This alternative implementation is
concurrency safe and is much more flexible with custom transports and
dialers.

The EC2Metadata Timeout override can also be disabled by setting the
EC2MetadataDisableTimeoutOverride `aws.Config` flag. This flag needs to
be passed into the Session or Config prior to creating the credentials
change and EC2RoleProvider.

Fix #509
    @jasdel
    jasdel committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    682d3f2 View commit details
    Browse the repository at this point in the history

  2. Simplify check if ec2metadata http client is provided

    @jasdel
    jasdel committed Jan 16, 2016
    Configuration menu
    Copy the full SHA
    32bb788 View commit details
    Browse the repository at this point in the history