-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/route53: Add batched error support for ChangeResourceRecordSets #593
Conversation
// needed, use BatchError | ||
// OrigErr returns the original error if one was set. Nil is returned if no | ||
// error was set. This only returns the first element in the list. If the full | ||
//list is needed, use BatchedErrors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd spacing on comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks will update that.
Was the |
Should probably add a leak test to the unit tests |
I was considering how best to represent For the leak test, not sure what to test there, there are no io.Read/Writers nor channels. What were you thinking should be tested? |
Yea, that makes sense, was just curious because it seems there would be more use in OrigErrs than in the OrigErr. So, I was thinking of concate the error messages together and returning that as a single error. However, after some thought, it may not be useful, since you can just call OrigErrs. Yea, I agree for the leak test there wouldn't be much to test there, but was thinking of having complete coverage of the services that have custom marshalers may be nice. |
Ah I see, for some reason I was thinking you meant for the error change. Yeah that makes sense for the route53 unmarshaller. I'll add that. |
BatchError did not satisfy the awserr.Error interface like it should of. This update adds a new type BatchedErrors which satisfies awserr.Error.
c0c8442
to
481a64c
Compare
|
LGTM, |
service/route53: Add batched error support for ChangeResourceRecordSets
service/route53: Add batched error support for ChangeResourceRecordSets
Adds support for batched errors that ChangeResourceRecordSets can
optionally return.
Replaces PR #438
Also deprecate BatchError in favor of BatchedErrors
BatchError did not satisfy the awserr.Error interface like it should of. This
update adds a new type BatchedErrors which satisfies awserr.Error.