Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the required Accept header for RPCv2 #5649

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

sugmanue
Copy link
Contributor

@sugmanue sugmanue commented Oct 8, 2024

Motivation and Context

RPCv2 needs the Accept header with value "application/cbor". See this open PR.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sugmanue sugmanue marked this pull request as ready for review October 8, 2024 18:52
@sugmanue sugmanue requested a review from a team as a code owner October 8, 2024 18:52
Copy link

sonarcloud bot commented Oct 8, 2024

@sugmanue sugmanue added this pull request to the merge queue Oct 8, 2024
Merged via the queue into master with commit 85857b5 Oct 8, 2024
17 checks passed
@sugmanue sugmanue deleted the sugmanue/rpcv2-add-accept-header branch October 30, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants