Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testChangedPackageNames prior to changeset publish #967

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 5, 2024

Issue

The testChangedPackageNames script was not run on publish

No changesets found. Attempting to publish any unpublished packages to npm
No user .npmrc file found, creating one
/usr/local/bin/npm run release

> aws-sdk-js-codemod@2.4.3 release
> npm run build && changeset publish

https://github.com/aws/aws-sdk-js-codemod/actions/runs/11678054032/job/32516955805

This happens as changesets does not run pre and post publish scripts changesets/changesets#982

Description

Move testChangedPackageNames prior to changeset publish

Testing

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner November 5, 2024 23:11
Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: cdab854

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trivikr trivikr merged commit d08e660 into main Nov 5, 2024
7 checks passed
@trivikr trivikr deleted the prepublish-script branch November 5, 2024 23:12
@trivikr
Copy link
Member Author

trivikr commented Nov 7, 2024

The script was run in v2.4.4 release

> aws-sdk-js-codemod@2.4.4 release
> tsx scripts/testUpdatedIdentifiers && npm run build && changeset publish

Changed package names: [  ]
Changed clients: [  ]

> aws-sdk-js-codemod@2.4.4 build
> tsc

https://github.com/aws/aws-sdk-js-codemod/actions/runs/11716737001/job/32635295989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant