Skip to content

Commit

Permalink
fix: ignore a protocol test for restjson server
Browse files Browse the repository at this point in the history
The test is wrong and will be fixed by
smithy-lang/smithy#2167
In the meantime, this commit ignores the invalid test.
  • Loading branch information
milesziemer committed Feb 27, 2024
1 parent c570437 commit 1e39eeb
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,13 @@ private static boolean filterProtocolTests(
return true;
}

// TODO: Remove when this test case is fixed upstream.
// https://github.com/smithy-lang/smithy/pull/2167
if (settings.generateServerSdk()
&& testCase.getId().equals("RestJsonZeroAndFalseQueryValues")) {
return true;
}

// TODO: remove when there's a decision on separator to use
// https://github.com/awslabs/smithy/issues/1014
if (testCase.getId().equals("RestJsonInputAndOutputWithQuotedStringHeaders")) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ it("RestJsonSupportsNegativeInfinityFloatQueryValues:ServerRequest", async () =>
/**
* Query values of 0 and false are serialized
*/
it("RestJsonZeroAndFalseQueryValues:ServerRequest", async () => {
it.skip("RestJsonZeroAndFalseQueryValues:ServerRequest", async () => {
const testFunction = jest.fn();
testFunction.mockReturnValue(Promise.resolve({}));
const testService: Partial<RestJsonService<{}>> = {
Expand Down

0 comments on commit 1e39eeb

Please sign in to comment.