Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use files field to ensure that only critical parts of the packages are shipped to users #1594

Closed
trivikr opened this issue Oct 21, 2020 · 4 comments
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Oct 21, 2020

Is your feature request related to a problem? Please describe.
JS SDK v3 packages doesn't use optional files field.

Describe the solution you'd like
Use files field to only ship critical parts to npm.

Describe alternatives you've considered
Not using files field.

@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Oct 21, 2020
@fishcharlie
Copy link

@trivikr Is this ever going to be prioritized?

@trivikr
Copy link
Member Author

trivikr commented Sep 17, 2021

Experimental PR to just publish files from dist folder trivikr/temp-client-s3#7
Package sizes documented in README https://github.com/trivikr/temp-client-s3

@trivikr
Copy link
Member Author

trivikr commented Oct 11, 2021

Fixed in #2873

@trivikr trivikr closed this as completed Oct 11, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

No branches or pull requests

2 participants