Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The generic-client-tests CI does not pick up changes from monorepo #2939

Closed
trivikr opened this issue Oct 27, 2021 · 4 comments · Fixed by #2954
Closed

The generic-client-tests CI does not pick up changes from monorepo #2939

trivikr opened this issue Oct 27, 2021 · 4 comments · Fixed by #2954
Labels
bug This issue is a bug.

Comments

@trivikr
Copy link
Member

trivikr commented Oct 27, 2021

Describe the bug

The generic-client-tests CI does not pick up changes from monorepo

Your environment

SDK version number

main

Is the issue in the browser/Node.js/ReactNative?

N/A

Details of the browser/Node.js/ReactNative version

N/A

Steps to reproduce

Export new code from utility packages, and import it from clients.
Example PR: #2937

Observed behavior

The generic-client-tests CI fails.

Expected behavior

The generic-client-tests test CI should not fail.

Additional context

Temporary fixes to build impacted packages in CI:

@trivikr trivikr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 27, 2021
@trivikr
Copy link
Member Author

trivikr commented Oct 27, 2021

One solution would be to create a private generic client, just like protocol_tests.
May be create a new workspace generic_client and copy aws-echo-service to it?

@AllanZhengYP
Copy link
Contributor

/cc @adamthom-amzn Can we move the aws-echo-service client to the workspace just like other protocol test clients?

@trivikr
Copy link
Member Author

trivikr commented Oct 27, 2021

Decision:

  • We will protocol tests and generic client in one folder (say private)
  • We will prefix something else for protocol tests in addition to aws-, say (aws-procotol-test-). This way, we know which workspaces in private are protocol tests.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants