Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): add useFipsEndpoint configuration #2937

Closed
wants to merge 6 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 27, 2021

Issue

Internal JS-2905
Internal JS-2906

Description

Adds useFipsEndpoint configuration:

  • Can be passed as a boolean or Provider<boolean> in client configuration.
  • Defaults to false for browser.
  • Reads from following places for Node.js
    • env["AWS_USE_FIPS_ENDPOINT"]
    • profile["use_fips_endpoint"]

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the config-use-fips-endpoint branch from e8c95ad to 875962a Compare October 27, 2021 15:47
@codecov-commenter
Copy link

Codecov Report

Merging #2937 (e8c95ad) into main (74e25df) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head e8c95ad differs from pull request most recent head 875962a. Consider uploading reports for the commit 875962a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2937      +/-   ##
==========================================
+ Coverage   58.57%   58.61%   +0.03%     
==========================================
  Files         558      559       +1     
  Lines       30249    30278      +29     
  Branches     7443     7459      +16     
==========================================
+ Hits        17719    17748      +29     
  Misses      12530    12530              
Impacted Files Coverage Δ
clients/client-sts/src/STSClient.ts 92.59% <0.00%> (ø)
clients/client-sts/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/src/runtimeConfig.ts 100.00% <0.00%> (ø)
clients/client-s3-control/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/src/EC2ProtocolClient.ts 92.00% <0.00%> (ø)
protocol_tests/aws-json-10/src/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restxml/src/runtimeConfig.ts 100.00% <0.00%> (ø)
clients/client-s3-control/src/S3ControlClient.ts 93.33% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e25df...875962a. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Oct 28, 2021

Superceded by #2947

@trivikr trivikr closed this Oct 28, 2021
@trivikr trivikr deleted the config-use-fips-endpoint branch October 28, 2021 03:38
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants