Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: commit all clients #324

Merged
merged 28 commits into from
Aug 19, 2019
Merged

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Aug 16, 2019

fix: #173

Commit all clients to the repo. This PR is too big for travis CI. The build succeeded on the CodeBuild.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Currently generated clients' config doesn't compatible with either
browser dependency or node dependency because the default streamType
is 'Uint8Array', which is not compatible with `Blob` or `Readable`
@AllanZhengYP AllanZhengYP force-pushed the commit-all-clients branch 2 times, most recently from 512c9f0 to 39ba17f Compare August 16, 2019 05:06
@AllanZhengYP AllanZhengYP marked this pull request as ready for review August 16, 2019 15:18
@AllanZhengYP AllanZhengYP requested a review from srchase August 16, 2019 15:24
@AllanZhengYP
Copy link
Contributor Author

This is ready to be reviewed.

@AllanZhengYP AllanZhengYP requested a review from trivikr August 19, 2019 15:59
@AllanZhengYP AllanZhengYP merged commit cb268ed into aws:master Aug 19, 2019
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most of Service Clients needs manually generated
2 participants