feat(smithy-client): add parse utils for sized numbers #2710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamthom-amzn
approved these changes
Aug 25, 2021
JordonPhillips
force-pushed
the
assert-number-size
branch
from
bda4d15 to
2f8ad81
Compare
Codecov Report
@@ Coverage Diff @@
## main #2710 +/- ##
=======================================
Coverage ? 61.40%
=======================================
Files ? 537
Lines ? 27520
Branches ? 6718
=======================================
Hits ? 16900
Misses ? 10620
Partials ? 0 Continue to review full report at Codecov.
|
JordonPhillips
force-pushed
the
assert-number-size
branch
2 times, most recently
from
77d1a41 to
3846251
Compare
JordonPhillips
force-pushed
the
assert-number-size
branch
from
d6d7a0b to
3846251
Compare
trivikr
changed the title
JordonPhillips
force-pushed
the
assert-number-size
branch
from
3846251 to
8eb0dbc
Compare
trivikr
requested changes
Aug 26, 2021
JordonPhillips
force-pushed
the
assert-number-size
branch
from
8eb0dbc to
ac8bca5
Compare
trivikr
requested changes
Aug 27, 2021
trivikr
approved these changes
Aug 30, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
This adds assertion and parse utilities for differently sized numbers.
Testing
So many tests.
Additional context
This depends on: smithy-lang/smithy-typescript#404
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.