Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant dot slash in directory configurations #2819

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 24, 2021

Issue

The dot slash is not used in clients

"outDir": "dist/cjs",

Description

Remove redundant dot slash in directory configurations

Testing

Integration tests were successful:

$ yarn test:integration
yarn run v1.22.11
$ jest --config jest.config.integ.js --passWithNoTests
 PASS  clients/client-transcribe-streaming/test/index.integ.spec.ts (29.635 s)
  TranscribeStream client
    ✓ should stream the transcript (28756 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        30.119 s, estimated 32 s
Ran all test suites.
Done in 30.78s.

$ yarn test:integration-legacy
yarn run v1.22.11
$ cucumber-js --fail-fast
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

150 scenarios (150 passed)
523 steps (523 passed)
1m38.478s
Done in 105.69s.

Additional context

Noticed while removing comments in #2817


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #2819 (bbea0c1) into main (d01420b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2819   +/-   ##
=======================================
  Coverage   60.41%   60.41%           
=======================================
  Files         554      554           
  Lines       28883    28883           
  Branches     7076     7076           
=======================================
  Hits        17450    17450           
  Misses      11433    11433           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01420b...bbea0c1. Read the comment docs.

@trivikr trivikr merged commit 732a838 into aws:main Sep 24, 2021
@trivikr trivikr deleted the remove-unnecessary-dotslash branch September 24, 2021 16:57
@github-actions
Copy link

github-actions bot commented Oct 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants