feat(codegen): do not pull client versions from packageInfo #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid having to @ts-ignore importing packageInfo from package.json, write the version contained in the typescript settings into the UserAgent provider's arguments. This removes the need to postprocess clients after they are generated.
Codecov Report
@@ Coverage Diff @@
## main #2860 +/- ##
=======================================
Coverage 60.42% 60.42%
=======================================
Files 554 554
Lines 28886 28886
Branches 7072 7072
=======================================
Hits 17453 17453
Misses 11433 11433 Continue to review full report at Codecov.
|
|
Superceded by #2875 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To avoid having to @ts-ignore importing packageInfo from package.json,
write the version contained in the typescript settings into the
UserAgent provider's arguments. This removes the need to postprocess
clients after they are generated.
Testing
I generated clients locally, as well as a white-label client that failed without manual postprocessing.
Additional context
This is just a demonstration of how we could drive versioning through updates to the central package.json, instead of lerna, since we generate a smithy-build that we can inject a version into before generation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.