Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): update clean:dist script to delete dist-* folder #3155

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 6, 2022

Issue

The script was updated when we moved client source code to src folder in smithy-lang/smithy-typescript#434
However, it as not overridden in existing clients as we do not override existing scripts.

Description

update clean:dist script to delete dist-* folder

Testing

Tested with client-acm

Before
$ yarn clean:dist
yarn run v1.22.17
$ rimraf ./dist
Done in 0.10s.

$ ls dist-*
dist-cjs:
ACMClient.js  endpoints.js  pagination                runtimeConfig.js         waiters
ACM.js        index.js      protocols                 runtimeConfig.native.js
commands      models        runtimeConfig.browser.js  runtimeConfig.shared.js

dist-es:
ACMClient.js  endpoints.js  pagination                runtimeConfig.js         waiters
ACM.js        index.js      protocols                 runtimeConfig.native.js
commands      models        runtimeConfig.browser.js  runtimeConfig.shared.js

dist-types:
ACMClient.d.ts  endpoints.d.ts  pagination                  runtimeConfig.d.ts         ts3.4
ACM.d.ts        index.d.ts      protocols                   runtimeConfig.native.d.ts  waiters
commands        models          runtimeConfig.browser.d.ts  runtimeConfig.shared.d.ts
After
$ yarn clean:dist
yarn run v1.22.17
$ rimraf ./dist-*
Done in 0.11s

$ ls dist-*
zsh: no matches found: dist-*

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 6, 2022 17:52
@trivikr trivikr force-pushed the update-clean-dist branch from 6c4d440 to c8d4629 Compare January 6, 2022 21:48
@trivikr trivikr merged commit cdb1709 into aws:main Jan 7, 2022
@trivikr trivikr deleted the update-clean-dist branch January 7, 2022 17:10
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants