Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): use json-stringify as parser for package.json #4559

Merged
merged 2 commits into from
Mar 21, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 20, 2023

Issue

Fixes #4558

Description

Use json-strigify as parser for JSON files

Testing

Verified that formatting does not get updated irrespective of from where it's done:

  • VSCode Prettier extension
  • Local prettier version through command line, or precommit script.
  • Clients codegen.

The updates in JSON files posted at [TBA]


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner March 20, 2023 23:13
@trivikr trivikr changed the title fix(scripts): use json-strigify as parser for JSON files fix(scripts): use json-stringify as parser for JSON files Mar 20, 2023
@trivikr trivikr changed the title fix(scripts): use json-stringify as parser for JSON files fix(scripts): use json-stringify as parser for package.json Mar 20, 2023
@trivikr trivikr merged commit 69f53ce into aws:main Mar 21, 2023
@trivikr trivikr deleted the scripts-json-stringify branch March 21, 2023 15:03
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The VSCode prettier plugin uses json-stringify as inferred parser for JSON overwriting prettified code
3 participants