Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocoltests): add aws-protocoltests-s3 #5166

Closed
wants to merge 4 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 1, 2023

Issue

Internal

Description

Adds aws-protocoltests-s3 to JS SDK v3

Testing

ToDo: CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Member Author

trivikr commented Sep 1, 2023

The aws-protocoltests-s3 protocol tests were not run under test:protocols because the test command was missing.

It was added in af424c2 (#5166)

@trivikr
Copy link
Member Author

trivikr commented Sep 1, 2023

Closing, as this PR was created for testing. A new PR will be created once tests are successful.

@trivikr trivikr closed this Sep 1, 2023
@trivikr trivikr deleted the aws-protocoltests-s3 branch September 1, 2023 17:11
@trivikr trivikr restored the aws-protocoltests-s3 branch September 1, 2023 17:16
@trivikr trivikr reopened this Sep 1, 2023
@trivikr trivikr closed this Sep 1, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
@trivikr trivikr deleted the aws-protocoltests-s3 branch June 7, 2024 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant