chore(client-sqs): create coercing serializers for awsQueryCompat #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
chore/sqs-protocol
branch
2 times, most recently
from
cf798b2 to
6cf6aea
Compare
kstich
reviewed
Oct 31, 2023
...codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/JsonShapeSerVisitor.java
Outdated
Show resolved
Hide resolved
kuhe
force-pushed
the
chore/sqs-protocol
branch
from
6cf6aea to
ff87524
Compare
kuhe
force-pushed
the
chore/sqs-protocol
branch
from
ff87524 to
f068d1a
Compare
trivikr
approved these changes
Oct 31, 2023
kstich
approved these changes
Oct 31, 2023
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
n/a
Description
create coercing serializers for use in JSON protocol services with the awsQueryCompatible trait.
Note: the first 2 commits apply the migrated model and codegen, the 3rd commit contains the protocol changes to be expected, and the last 2 commits remove the migrated model and codegen.
the overall diff is only the codegen changes without application to any model.
Testing
unit tests, manual sqs testing
SQS e2e subset: