-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add AccountIdEndpointMode config option #6036
Conversation
...ava/software/amazon/smithy/aws/typescript/codegen/AddAccountIdEndpointModeRuntimeConfig.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/aws/typescript/codegen/AddAccountIdEndpointModeRuntimeConfig.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/aws/typescript/codegen/AddAccountIdEndpointModeRuntimeConfig.java
Show resolved
Hide resolved
...ava/software/amazon/smithy/aws/typescript/codegen/AddAccountIdEndpointModeRuntimeConfig.java
Show resolved
Hide resolved
...ava/software/amazon/smithy/aws/typescript/codegen/AddAccountIdEndpointModeRuntimeConfig.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/aws/typescript/codegen/AddAccountIdEndpointModeRuntimeConfig.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/aws/typescript/codegen/AddAccountIdEndpointModeRuntimeConfig.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/aws/typescript/codegen/AddAccountIdEndpointModeRuntimeConfig.java
Outdated
Show resolved
Hide resolved
...ava/software/amazon/smithy/aws/typescript/codegen/AddAccountIdEndpointModeRuntimeConfig.java
Outdated
Show resolved
Hide resolved
possibly requires a careful look: exporting from [EDIT]: added a TODO to use |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Internal JS-4633
Part 3
Description
Adds support for
AccountIdEndpointMode
config option. (client config, env, config file)Testing
ClientInputEndpointParameters
example:
(this is before the merging of #6035 which is why
accountId
is generated as well)runtimeConfig.ts
example:
@aws-sdk/core/account-id-endpoint
instead of just@aws-sdk/core
Example:
runtimeConfig.browser.ts
example:
Checklist
core/submodules
@public
tag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.