Specify ContentLength for part uploads #6131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
May 24, 2024
lib/lib-storage/src/Upload.ts
Outdated
| @@ -276,6 +276,7 @@ export class Upload extends EventEmitter { | |||
| const partResult = await this.client.send( | |||
| new UploadPartCommand({ | |||
| ...this.params, | |||
| ContentLength: partSize || undefined, | |||
There was a problem hiding this comment.
any reason not to always set this to undefined?
the body, dataPart.data might always be a buffered value with known length
There was a problem hiding this comment.
I figured that if the information was there, it might as well be passed. Without knowing the details of how S3 uses that information I don't know if it would be helpful to include it or not, but I don't think there's a down side to including it.
kuhe
approved these changes
Jun 14, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#4767
Description
The
UploadPartCommandis passed the original parameters, which may includeContentLength. If theContentLengthis included in the original parameters, and the upload is larger than a single chunk,UploadPartCommandhas an incorrect value forContentLength. This change passes the actual size of the chunk asContentLength, or makes sure it is undefined if the part size is not calculated.Testing
After upgrading from SDK v2 to v3, our uploads were hanging and eventually timing out. Making this change in our local copy of the SDK fixed the uploads.
Additional context
Checklist
@publictag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.