chore(middleware-sdk-s3): update s3 status 200 error handling #6232
+276
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
chore/s3-200-error
branch
5 times, most recently
from
b7585ac
to
140913b
Compare
siddsriv
approved these changes
Jun 27, 2024
isaiahshall
approved these changes
Jun 27, 2024
trivikr
approved these changes
Jun 27, 2024
|
updated to require smithy-lang/smithy-typescript#1336 uses stream splitting instead of turning the stream into a bytearray, which is incompatible for event streams |
kuhe
force-pushed
the
chore/s3-200-error
branch
4 times, most recently
from
7a04eaa
to
1a8882b
Compare
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
internal
Depends on #6279 being merged
Description
Updates the s3 status 200 error behavior. For JSv3 middleware, the change is to ignore the
<Error>tag within a 200 response if it is not the top level XML element.For Command criteria, it is no longer an allowlist, rather any operation that does not have a response payload of type blob with streaming trait.
Testing
Added unit test.