Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing @smithy/core dependency in @aws-sdk/lib-dynamodb #6384

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

stekycz
Copy link
Contributor

@stekycz stekycz commented Aug 14, 2024

Description

Changes in 922292b introduced a new direct dependency on @smithy/core. It was forgotten to be added to package.json.

Additional context

This becomes an issue in environments where production dependencies only are distributed.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stekycz stekycz requested a review from a team as a code owner August 14, 2024 08:45
@kuhe kuhe merged commit 84fd78b into aws:main Aug 14, 2024
2 checks passed
@stekycz stekycz deleted the patch-1 branch August 15, 2024 04:16
Copy link

github-actions bot commented Sep 2, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants