Add missing generic parameter to ReadableStream type #6554
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added to the upstream dom typings in the Nov 2018 update.
ref:
microsoft/TypeScript@b830ef8
microsoft/TypeScript#28343
microsoft/TypeScript-DOM-lib-generator#541
Issue
n/a
Description
This updates the
ReadableStream
type to match the upstreamdom.d.ts
from which it was mirrored in the first place.This is needed because otherwise it can result in errors like these:
Testing
I tested this by making the change in my
node_modules
folder and building and testing our project.Additional context
Add any other context about the PR here.
Checklist
@public
tag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.