test: throw final error in turbo script #6594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
previously approved these changes
Oct 28, 2024
This comment was marked as outdated.
This comment was marked as outdated.
kuhe
commented
Oct 28, 2024
| @@ -28,10 +28,7 @@ const runTurbo = async (task, args, { apiSecret, apiEndpoint, apiSignatureKey } | |||
| }); | |||
| } catch (error) { | |||
| console.error("Error running turbo:", error); | |||
| if (args?.length > 0) { | |||
| // Retry without additional filters | |||
| return await runTurbo(task, null, apiSecret, apiEndpoint); | |||
There was a problem hiding this comment.
the null never worked since args is spread above. And now, the arguments structure is different anyway.
trivikr
approved these changes
Oct 29, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw the final error in the Turbo wrapper script instead of only logging it.
Internal JS-5525