fix: honor httpChecksumRequired in sigv2

aws · Sep 30, 2021 · 6d8988a · 6d8988a
1 parent 7efca93
commit 6d8988a
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 16 deletions.
diff --git a/.changes/next-release/bugfix-Signer-bb5ba0f7.json b/.changes/next-release/bugfix-Signer-bb5ba0f7.json
@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "Signer",
+  "description": "Fix the bug that httpChecksumRequired trait is not honored in SigV2"
+}
diff --git a/lib/event_listeners.js b/lib/event_listeners.js
@@ -147,7 +147,6 @@ AWS.EventListeners = {
         operation.httpChecksumRequired &&
         req.service.config.computeChecksums &&
         isNonStreamingPayload &&
-        req.service.getSignerClass(req) === AWS.Signers.V4 &&
         !headers['Content-MD5']
       ) {
         var md5 = AWS.util.crypto.md5(body, 'base64');

diff --git a/lib/services/s3.js b/lib/services/s3.js
@@ -430,21 +430,6 @@ AWS.util.update(AWS.S3.prototype, {
     }
   },
 
-  /**
-   * @api private
-   */
-  computableChecksumOperations: {
-    putBucketCors: true,
-    putBucketLifecycle: true,
-    putBucketLifecycleConfiguration: true,
-    putBucketTagging: true,
-    deleteObjects: true,
-    putBucketReplication: true,
-    putObjectLegalHold: true,
-    putObjectRetention: true,
-    putObjectLockConfiguration: true
-  },
-
   /**
    * Checks whether checksums should be computed for the request if it's not
    * already set by {AWS.EventListeners.Core.COMPUTE_CHECKSUM}. It depends on

diff --git a/test/event_listeners.spec.js b/test/event_listeners.spec.js