ManagedUpload.send's callback may return null instead of an Error

[jaller94]

This callback's TypeScript definition says it would always return an AWSError, however, by looking at the actual code and JSDocs one notices that the err may also be null.

aws-sdk-js/lib/s3/managed_upload.js

Line 159 in a42ad57

* @param err [Error] an error or null if no error occurred.

I don't intent to maintain this PR – I just though a code change would be more descriptive than filing an issue. Please edit this or commit it yourself if you must not have contributors without CLA signature in your code.

Checklist

• npm run test passes
• .d.ts file is updated
• changelog is added, npm run add-change
• run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
• run npm run integration if integration test is changed
• non-code related change (markdown/git settings etc)

[github-actions]

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

[jaller94]

This type error still exists.

Based on recent reviews, @kuhe, could you have a look at this please?

[github-actions]

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

[jaller94]

This is still an issue and even the TypeScript types now have this incorrect type assumption.

aws-sdk-js/lib/s3/managed_upload.d.ts

Line 19 in 49f5d76

send(callback?: (err: AWSError, data: ManagedUpload.SendData) => void): void;