Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IAsyncEnumerable #1482

Closed
wants to merge 2 commits into from
Closed

Support IAsyncEnumerable #1482

wants to merge 2 commits into from

Conversation

sudoudaisuke
Copy link

@sudoudaisuke sudoudaisuke commented Dec 11, 2019

Description

Add netstandard2.1 to TargetFrameworkds.
Add PachageReference Microsoft.Bcl.AsyncInterfaces to netstandard 2.0.
Implement IAsyncEnumerable for AsyncSearch on netstandard 2.0 and netstandard 2.1.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

Add netstandard2.1 to TargetFrameworkds
Add PachageReference Microsoft.Bcl.AsyncInterfaces to netstandard 2.0
Implement IAsyncEnumerable for AsyncSearch on netstandard 2.0 and netstandard 2.1
Implement IAsyncEnumerable for Search
@matteo-prosperi
Copy link
Contributor

Hello,
thank you for your PR.
Unfortunately we would not be able to add dependency on a new package or add a new target through a PR due to backward compatibility concerns. This will require more complex coordination and structural work across the SDK.
Nonetheless, this is great input and we will consider this in the context of some larger work we are doing in the SDK.
I am closing this for now.

@matteo-prosperi matteo-prosperi added breaking-change This issue requires a breaking change to remediate. needs-design labels Feb 25, 2020
@say25
Copy link

say25 commented Feb 26, 2020

@matteo-prosperi any hints on when native support for this feature could be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This issue requires a breaking change to remediate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants