Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom implementation of CopyStream with CopyTo #3292

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Replace custom implementation of CopyStream with CopyTo #3292

merged 1 commit into from
Apr 22, 2024

Conversation

danielmarbach
Copy link
Contributor

@danielmarbach danielmarbach commented Apr 21, 2024 •
edited
Loading

Description

Replaces the custom implementation of CopyStream with the stream based CopyTo method that has more efficient implementations.

Motivation and Context

Testing

I ran benchmarks against MemoryStream since that seems to be the most used version of Stream in the cases I quickly checked against

Screenshots (if appropriate)

Screenshot 2024-04-21 at 23 02 49

https://github.com/danielmarbach/aws-sdk-net-benchmarks/blob/main/StreamCopy.cs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

normj
normj approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved now we are not target .NET Framework 3.5 and CopyTo always exist in all of V4's targets.

@dscpinheiro dscpinheiro added the v4 label Apr 22, 2024
@normj normj merged commit 815db56 into aws:v4-development Apr 22, 2024
5 checks passed
@danielmarbach danielmarbach deleted the stream-copy branch April 24, 2024 19:40
@normj normj mentioned this pull request Jun 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscpinheiro dscpinheiro dscpinheiro approved these changes

@normj normj normj approved these changes

Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielmarbach @normj @dscpinheiro