Create tracing spans to cover the SDK operations #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-othman
commented
Jun 24, 2024
| } | ||
| finally | ||
| { | ||
| executionContext.RequestContext.Metrics.StopEvent(Metric.ClientExecuteTime); | ||
| this.LogMetrics(executionContext); | ||
| span.Dispose(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I intentionally left out adding traces for AWS_APM_API (.NET Framework 3.5) because we plan to remove it in v4 and including it would introduce unnecessary complexity to store the spans and retrieve them in the InvokeCallback, which will not be needed in the newer versions.
Additionally, none of our customers will benefit from it as OTel is not supported for .NET Framework versions older than 4.6.2.
normj
requested changes
Jun 26, 2024
| /// <param name="spanKind">Optional type of span to create.</param> | ||
| /// <param name="parentContext">Optional parent context for the span.</param> | ||
| /// <returns>A <see cref="TraceSpan"/> instance representing the created span.</returns> | ||
| public static TraceSpan CreateSpanHelper( |
There was a problem hiding this comment.
Adding the Helper suffix is redundant because you are in a class of utilities. It also makes me think it returns back an object that has helper methods for creating spans. I would remove the Helper suffix.
muhammad-othman
force-pushed
the
muhamoth/DOTNET-7519-Observability-Create-tracing-spans
branch
from
7701da6
to
8569b06
Compare
normj
approved these changes
Jun 26, 2024
afroz429
approved these changes
Jun 27, 2024
muhammad-othman
merged commit c614f0b
into
DOTNET-7462-Observability-for-the-NET-SDK
1 check passed
muhammad-othman
deleted the
muhamoth/DOTNET-7519-Observability-Create-tracing-spans
branch
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created new tracing spans in the following places:
Motivation and Context
https://sim.amazon.com/issues/DOTNET-7519
Testing
Created a hacked OTel provider, ran same requests and checked the output in the console and visualized these traces in observability tools, here are some examples:
Full tracing timeline
PutObject attributes:
GetObject attributes:
DynamoDB.UpdateItem
DynamoDB.DescribeTableRequest with exception attributes:
Screenshots (if appropriate)
Types of changes
Checklist
License