Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deserialization error when reading from DynamoDB using KeyConditionExpression #2607

Merged
merged 6 commits into from
Jan 11, 2024
Merged

fix: Deserialization error when reading from DynamoDB using KeyConditionExpression #2607

merged 6 commits into from
Jan 11, 2024

Conversation

LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented Jan 11, 2024 •
edited
Loading

Feature or Bugfix

  • Bugfix

Detail

  • Fix deserialization error when reading from DynamoDB using KeyConditionExpression
  • Added unit tests to make sure the output has been deserialized for all the different read options in the DynamoDB module
  • Upgraded unit tests to check for DataFrame equality

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LeonLuttenberger LeonLuttenberger linked an issue Jan 11, 2024 that may be closed by this pull request
Breaking change in awswrangler.dynamodb.read_items with version 3.5.0 #2605
Closed
@LeonLuttenberger LeonLuttenberger self-assigned this Jan 11, 2024
@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review January 11, 2024 16:55
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 067343e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 067343e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger merged commit 57330fd into main Jan 11, 2024
19 checks passed
@LeonLuttenberger LeonLuttenberger deleted the 2605-breaking-change-in-awswranglerdynamodbread_items-with-version-350 branch January 11, 2024 19:52
@kukushking kukushking mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malachi-constant malachi-constant malachi-constant approved these changes

@kukushking kukushking kukushking approved these changes

@jaidisido jaidisido Awaiting requested review from jaidisido

Assignees

@LeonLuttenberger LeonLuttenberger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking change in awswrangler.dynamodb.read_items with version 3.5.0
4 participants
@LeonLuttenberger @malachi-constant @kukushking @jaidisido