Implement more ReturnTypeWillChange attributes (#2284)

* Implement ReturnTypeWillChange

src/Api/AbstractModel.php

@@ -27,22 +27,26 @@ public function toArray()
         return $this->definition;
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetGet($offset)
     {
         return isset($this->definition[$offset])
             ? $this->definition[$offset] : null;
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetSet($offset, $value)
     {
         $this->definition[$offset] = $value;
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetExists($offset)
     {
         return isset($this->definition[$offset]);
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetUnset($offset)
     {
         unset($this->definition[$offset]);

src/Api/DateTimeResult.php

@@ -4,7 +4,6 @@
 
 use Aws\Api\Parser\Exception\ParserException;
 use Exception;
-use \ReturnTypeWillChange;
 
 /**
  * DateTime overrides that make DateTime work more seamlessly as a string,
@@ -95,10 +94,9 @@ public function __toString()
      *
      * @return mixed|string
      */
-    #[ReturnTypeWillChange]
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return (string) $this;
     }
 }
-

src/CloudTrail/LogRecordIterator.php

@@ -110,11 +110,13 @@ public function __construct(
      *
      * @return array|false
      */
+    #[\ReturnTypeWillChange]
     public function current()
     {
         return $this->valid() ? $this->records[$this->recordIndex] : false;
     }
 
+    #[\ReturnTypeWillChange]
     public function next()
     {
         $this->recordIndex++;
@@ -131,6 +133,7 @@ public function next()
         }
     }
 
+    #[\ReturnTypeWillChange]
     public function key()
     {
         if ($logFile = $this->logFileIterator->current()) {
@@ -140,17 +143,20 @@ public function key()
         return null;
     }
 
+    #[\ReturnTypeWillChange]
     public function valid()
     {
         return isset($this->records[$this->recordIndex]);
     }
 
+    #[\ReturnTypeWillChange]
     public function rewind()
     {
         $this->logFileIterator->rewind();
         $this->loadRecordsFromCurrentLogFile();
     }
 
+    #[\ReturnTypeWillChange]
     public function getInnerIterator()
     {
         return $this->logFileIterator;

src/Crypto/MetadataEnvelope.php

@@ -6,7 +6,6 @@
 use \IteratorAggregate;
 use \InvalidArgumentException;
 use \JsonSerializable;
-use \ReturnTypeWillChange;
 
 /**
  * Stores encryption metadata for reading and writing.
@@ -50,7 +49,7 @@ public function offsetSet($name, $value)
         $this->data[$name] = $value;
     }
 
-    #[ReturnTypeWillChange]
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return $this->data;

src/DynamoDb/BinaryValue.php

@@ -2,7 +2,6 @@
 namespace Aws\DynamoDb;
 
 use GuzzleHttp\Psr7;
-use \ReturnTypeWillChange;
 
 /**
  * Special object to represent a DynamoDB binary (B) value.
@@ -25,7 +24,7 @@ public function __construct($value)
         $this->value = (string) $value;
     }
 
-    #[ReturnTypeWillChange]
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return $this->value;

src/DynamoDb/NumberValue.php

@@ -1,8 +1,6 @@
 <?php
 namespace Aws\DynamoDb;
 
-use \ReturnTypeWillChange;
-
 /**
  * Special object to represent a DynamoDB Number (N) value.
  */
@@ -19,7 +17,7 @@ public function __construct($value)
         $this->value = (string) $value;
     }
 
-    #[ReturnTypeWillChange]
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return $this->value;

src/DynamoDb/SessionHandler.php

@@ -1,8 +1,6 @@
 <?php
 namespace Aws\DynamoDb;
 
-use \ReturnTypeWillChange;
-
 /**
  * Provides an interface for using Amazon DynamoDB as a session store by hooking
  * into PHP's session handler hooks. Once registered, You may use the native
@@ -103,7 +101,7 @@ public function register()
      *
      * @return bool Whether or not the operation succeeded.
      */
-     #[ReturnTypeWillChange]
+     #[\ReturnTypeWillChange]
     public function open($savePath, $sessionName)
     {
         $this->savePath = $savePath;
@@ -117,7 +115,7 @@ public function open($savePath, $sessionName)
      *
      * @return bool Success
      */
-     #[ReturnTypeWillChange]
+     #[\ReturnTypeWillChange]
     public function close()
     {
         $id = session_id();
@@ -138,7 +136,7 @@ public function close()
      *
      * @return string Session data.
      */
-     #[ReturnTypeWillChange]
+     #[\ReturnTypeWillChange]
     public function read($id)
     {
         $this->openSessionId = $id;
@@ -172,7 +170,7 @@ public function read($id)
      *
      * @return bool Whether or not the operation succeeded.
      */
-     #[ReturnTypeWillChange]
+     #[\ReturnTypeWillChange]
     public function write($id, $data)
     {
         $changed = $id !== $this->openSessionId
@@ -193,7 +191,7 @@ public function write($id, $data)
      *
      * @return bool Whether or not the operation succeeded.
      */
-     #[ReturnTypeWillChange]
+     #[\ReturnTypeWillChange]
     public function destroy($id)
     {
         $this->openSessionId = $id;
@@ -213,7 +211,7 @@ public function destroy($id)
      * @return bool Whether or not the operation succeeded.
      * @codeCoverageIgnore
      */
-     #[ReturnTypeWillChange]
+     #[\ReturnTypeWillChange]
     public function gc($maxLifetime)
     {
         // Garbage collection for a DynamoDB table must be triggered manually.

src/DynamoDb/SetValue.php

@@ -1,8 +1,6 @@
 <?php
 namespace Aws\DynamoDb;
 
-use \ReturnTypeWillChange;
-
 /**
  * Special object to represent a DynamoDB set (SS/NS/BS) value.
  */
@@ -29,17 +27,19 @@ public function toArray()
         return $this->values;
     }
 
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->values);
     }
 
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new \ArrayIterator($this->values);
     }
 
-    #[ReturnTypeWillChange]
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return $this->toArray();

src/HandlerList.php

@@ -305,6 +305,7 @@ public function resolve()
         return $prev;
     }
 
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->steps[self::INIT])

src/HasDataTrait.php

@@ -10,6 +10,7 @@ trait HasDataTrait
     /** @var array */
     private $data = [];
 
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new \ArrayIterator($this->data);
@@ -23,6 +24,7 @@ public function getIterator()
      *
      * @return mixed|null
      */
+    #[\ReturnTypeWillChange]
     public function & offsetGet($offset)
     {
         if (isset($this->data[$offset])) {
@@ -33,16 +35,19 @@ public function & offsetGet($offset)
         return $value;
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetSet($offset, $value)
     {
         $this->data[$offset] = $value;
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetExists($offset)
     {
         return isset($this->data[$offset]);
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetUnset($offset)
     {
         unset($this->data[$offset]);
@@ -53,6 +58,7 @@ public function toArray()
         return $this->data;
     }
 
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->data);

src/History.php

@@ -21,11 +21,13 @@ public function __construct($maxEntries = 10)
         $this->maxEntries = $maxEntries;
     }
 
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->entries);
     }
 
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new \ArrayIterator(array_values($this->entries));

src/LruArrayCache.php

@@ -72,6 +72,7 @@ public function remove($key)
         unset($this->items[$key]);
     }
 
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->items);

src/MockHandler.php

@@ -139,6 +139,7 @@ public function getLastCommand()
      *
      * @return int
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->queue);