enhancement: hostname resolution (#2831)

aws · Nov 20, 2023 · f1bd5c0 · f1bd5c0
1 parent 06978bf
commit f1bd5c0
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 1 deletion.
diff --git a/.changes/nextrelease/update-http-credentials.json b/.changes/nextrelease/update-http-credentials.json
@@ -0,0 +1,7 @@
+[
+  {
+    "type": "enhancement",
+    "category": "Credentials",
+    "description": "Adds hostname resolution for the EcsCredentialProvider."
+  }
+]
diff --git a/src/Credentials/EcsCredentialProvider.php b/src/Credentials/EcsCredentialProvider.php
@@ -192,7 +192,7 @@ private function isCompatibleUri($uri)
             if ($host !== $ecsHost
                 && $host !== $eksHost
                 && $host !== self::EKS_SERVER_HOST_IPV6
-                && !$this->isLoopbackAddress($host)
+                && !$this->isLoopbackAddress(gethostbyname($host))
             ) {
                 return false;
             }

diff --git a/tests/Credentials/fixtures/ecs/uri-token-resolution.json b/tests/Credentials/fixtures/ecs/uri-token-resolution.json
@@ -62,6 +62,34 @@
         }
       }
     },
+    {
+      "description": "http loopback(v4) with host resolution (no port)",
+      "env": {
+        "AWS_CONTAINER_CREDENTIALS_FULL_URI": "http://localhost/credentials"
+      },
+      "expect": {
+        "type": "success",
+        "request": {
+          "method": "GET",
+          "uri": "http://localhost/credentials",
+          "headers": {}
+        }
+      }
+    },
+    {
+      "description": "http loopback(v4) with host resolution (port)",
+      "env": {
+        "AWS_CONTAINER_CREDENTIALS_FULL_URI": "http://localhost:8080/credentials"
+      },
+      "expect": {
+        "type": "success",
+        "request": {
+          "method": "GET",
+          "uri": "http://localhost:8080/credentials",
+          "headers": {}
+        }
+      }
+    },
     {
       "description": "http loopback(v6) URI",
       "env": {