Test on PHP 8.0 #2268
Closed
Test on PHP 8.0 #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't seem to start the tests to run unless I get approval because of GitHub's new policies. Therefor I have no idea if the test suite will pass or not. After approval has been given I can look into making the tests pass. I also can't run them locally because an incompatible PHPUnit version is loaded because of its very loose constraints: https://github.com/sebastianbergmann/phpunit/blob/4.8.36/composer.json#L23 |
|
Going to close this one as there's much work to be done to migrate the entire test suite to a newer PHPUnit version. I unfortunately don't have the time for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows the library to be built on PHP 8.