Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit deprecation warning #2547

Merged
merged 30 commits into from
Feb 17, 2023
Merged

Emit deprecation warning #2547

merged 30 commits into from
Feb 17, 2023

Conversation

SamRemis
Copy link
Member

@SamRemis SamRemis commented Oct 21, 2022 •
edited
Loading

@SamRemis SamRemis changed the title Emit deprecation warning - date tentative Emit deprecation warning Oct 21, 2022
stobrien89
stobrien89 reviewed Feb 8, 2023
View reviewed changes
tests/bootstrap.php Outdated Show resolved Hide resolved
stobrien89
stobrien89 reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@stobrien89 stobrien89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few updates needed, but like how the fallbacks are structured now

src/ClientResolver.php Outdated Show resolved Hide resolved
src/ClientResolver.php Outdated Show resolved Hide resolved
src/ClientResolver.php Outdated Show resolved Hide resolved
@SamRemis SamRemis merged commit ceb929c into aws:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stobrien89 stobrien89 stobrien89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamRemis @stobrien89