Fix negative DelaySeconds being passed to parameter. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we fix Rubocop please? |
added 2 commits
December 13, 2023 07:28
Issue: aws#106
```
Inspecting 53 files
........................C............................
Offenses:
lib/generators/aws_record/base.rb:150:9: C: [Corrected] Style/HashEachMethods: Use each_key instead of each and remove the unused _rw_units block argument.
options['table_config'].each do |config, _rw_units| ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
53 files inspected, 1 offense detected, 1 offense corrected
Tip: Based on detected gems, the following RuboCop extension libraries might be helpful:
* rubocop-rails (https://rubygems.org/gems/rubocop-rails)
You can opt out of this message by adding the following to your config (see https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions for more options):
AllCops:
SuggestExtensions: false
```
kyto64
force-pushed
the
fix-negative-delay
branch
from
3fffc4a
to
ef03396
Compare
fixed. @mullermp @alextwoods |
kyto64
changed the title
|
Thanks for your contribution. I forgot this needs a changelog entry. I'll add one. I can try to get a release out this week if not next week. |
|
@mullermp |
|
I'm sorry, I got caught up with other things. I will do this today. |
|
Released as 3.9.1 |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #106
Description of changes:
I fixed delay time to be 0 seconds when no delay or negative delay is set.
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.