ci: report "npm WARN deprecated" #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
Deprecated dependencies may not be noticed for a long time.
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated winston@3.7.1: Please use version 3.6.0 or >3.7.1 when available due to winstonjs/winston#2103
Solution:
Collect these warnings when running CI.
TODO: fail if new warnings are found.
justinmk3
force-pushed
the
cideprecateddeps
branch
from
1a87c30
to
9ef497c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Deprecated dependencies may not be noticed for a long time.
Solution:
Collect these warnings when running CI.
TODO: fail if new warnings are found.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.