feat(amazonq): enable SQL conversions feature #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dhasani23
changed the title
dhasani23
commented
Nov 8, 2024
|
TODO: add changelog entry |
dhasani23
force-pushed
the
dmsUpdates
branch
5 times, most recently
from
c5a5a14
to
112bd34
Compare
justinmk3
reviewed
Nov 13, 2024
| @@ -80,6 +81,7 @@ import { setContext } from '../../shared/vscode/setContext' | |||
| import { makeTemporaryToolkitFolder } from '../../shared' | |||
| import globals from '../../shared/extensionGlobals' | |||
| import { convertDateToTimestamp } from '../../shared/datetime' | |||
| import { spawnSync } from 'child_process' | |||
There was a problem hiding this comment.
use our ChildProcess wrapper unless there is a technical reason why it can't be used.
It has logging, and will eventually gain some performance-tracking and telemetry features.
justinmk3
reviewed
Nov 13, 2024
| // as long as at least one of these strings is found, project contains embedded SQL statements | ||
| const searchStrings = ['oracle.jdbc.OracleDriver', 'jdbc:oracle:thin:@//', 'jdbc:oracle:oci:@//'] | ||
| for (const str of searchStrings) { | ||
| const command = process.platform === 'win32' ? 'findstr' : 'grep' |
There was a problem hiding this comment.
there is a isWin util function
added 11 commits
November 14, 2024 12:57
dhasani23
force-pushed
the
dmsUpdates
branch
from
63322df
to
09de871
Compare
dhasani23
commented
Nov 15, 2024
| @@ -624,6 +639,14 @@ export class GumbyController { | |||
|
|
|||
| case ConversationState.WAITING_FOR_TRANSFORMATION_OBJECTIVE: { | |||
| const objective = data.message.trim().toLowerCase() | |||
| // since we're prompting the user, their project(s) must be eligible for both types of transformations, so track how often this happens here | |||
| if (objective === 'language upgrade' || objective === 'sql conversion') { | |||
| telemetry.codeTransform_submitSelection.emit({ | |||
There was a problem hiding this comment.
Best practice to use a run block, but I don't have anything to do here, just want to emit a metric to track how often the user gets to this point because it's meaningful for us. Furthermore, handleLanguageUpgrade and handleSQLConversion below already emit a validateProject metric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Enable the SQL conversion feature for
/transform.Solution
Enable feature, intended for 11/21 release.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.