Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notification): misc logging, types, fixes #6004

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat(notification): misc logging, types, fixes #6004

wants to merge 5 commits into from
+117 −71

Conversation

hayemaxi
Copy link
Contributor

Don't squash

Commit messages are complete.
Summary:

  • Remove unneeded criteria rule
  • Add verbose logging for rule checks
  • Add types that were missing to parts of the notification schema. Some were just strings but had predefined values
  • Add a timeout to the update and reload action so that telemetry can run.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@hayemaxi
refactor(notifications): remove unneeded InstalledExtensions criteria
74b3c47 
We have both ActiveExtensions (checks what extensions are installed and active), and InstalledExtensions (just what extensions are installed).
This removes InstalledExtensions because most of the intention behind it is captured by ActiveExtensions. When would we only care about whats installed but not active?

Removing a criteria decreases complexity and confusion in both code and for those drafting notifications, so this is an easy removal.
@hayemaxi
types(notifications): add types to onClick, onReceive, actions
9a81077
@hayemaxi hayemaxi force-pushed the notifications-3 branch 3 times, most recently from 0735573 to 5661ec0 Compare November 14, 2024 23:13
@hayemaxi
fix(notifications): add timeout to update and reload
fd00403 
Telemetry needs time to be sent, maybe other cleanup routines as well.
Also, make sure to flush telemetry before reloading so it isn't lost.
@hayemaxi
fix(notifications): icons causing runtime error
0418b00 
Problem: Making the icon red for emergency notifications requires changing the color property. To do it in 1 line we use a ternary statement and unwrap. This causes runtime error similar to: `cannot access property of undefined: 0`.

Solution: Use object.assign instead
@hayemaxi
feat(notifications): adjust wording and add activity bar badge
860b441 
- Remove description from the notifications panel - unneeded. It is obvious the panel is for notifications.
- Make hover text the full title of the notification in case user side bar width isn't enough to display the full title.
- Add a badge to the Q activity bar icon indicating how many notifications you have. Also adds this as (#) to the panel title.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk3 justinmk3 justinmk3 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hayemaxi @justinmk3