Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appbuilder): Issue related to App-builder placeholder wrong message #6010

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

jonife
Copy link
Contributor

@jonife jonife commented Nov 13, 2024

Problem

I was working on a CDK project, and after synthesizing my CDK template, I noticed that the app-builder is showing a misleading notification to customers: No IaC templates found in the workspace. This seems incorrect, as I do have IaC templates in the workspace, including both raw and synthesized CDK templates.

Screenshot 2024-11-05 at 9 30 15 AM

While I understand the intention behind the message, it needs to be more precise to avoid confusion. I suggest we roll it back to something more accurate, like No SAM templates found in the workspace, to clearly indicate the specific missing template type. I'm considering this a P0 issue and will raise a PR to address it.

Solution

Solution is to change all instance where IAC is mentioned to the customer to SAM, we would roll back to IaC once we start support CDK.

Remove redundant Logic.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonife jonife requested a review from a team as a code owner November 13, 2024 22:40
@jonife jonife changed the title (Fix): Issue related to App-builder placeholder wrong message fix(Appbuilder): Issue related to App-builder placeholder wrong message Nov 13, 2024
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jonife jonife changed the title fix(Appbuilder): Issue related to App-builder placeholder wrong message fix(appbuilder): Issue related to App-builder placeholder wrong message Nov 13, 2024
@justinmk3
Copy link
Contributor

I improved the changelog. Please review https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#changelog for future PRs.

@justinmk3 justinmk3 merged commit 4531668 into aws:master Nov 14, 2024
10 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants